mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
1432065e9d
Historically `error.errno` of system errors thrown by Node.js
can sometimes be the same as `err.code`, which are string
representations of the error numbers. This is useless and incorrect,
and results in an information loss for users since then they
will have to resort to something like
`process.binding('uv'[`UV_${errno}`])` to get to the numeric
error codes.
This patch corrects this behavior by always setting `error.errno`
to be negative numbers. For fabricated errors like `ENOTFOUND`,
`error.errno` is now undefined since there is no numeric equivalent
for them anyway. For c-ares errors, `error.errno` is now undefined
because the numeric representations (negated) can be in conflict
with libuv error codes - this is fine since numeric codes was
not available for c-ares errors anyway.
Users can use the public API `util.getSystemErrorName(errno)`
to retrieve string codes for these numbers.
PR-URL: https://github.com/nodejs/node/pull/28140
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
71 lines
2.0 KiB
JavaScript
71 lines
2.0 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const dgram = require('dgram');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const { UV_UNKNOWN } = internalBinding('uv');
|
|
const { getSystemErrorName } = require('util');
|
|
const { kStateSymbol } = require('internal/dgram');
|
|
const mockError = new Error('mock DNS error');
|
|
|
|
function getSocket(callback) {
|
|
const socket = dgram.createSocket('udp4');
|
|
|
|
socket.on('message', common.mustNotCall('Should not receive any messages.'));
|
|
socket.bind(common.mustCall(() => {
|
|
socket[kStateSymbol].handle.lookup = function(address, callback) {
|
|
process.nextTick(callback, mockError);
|
|
};
|
|
|
|
callback(socket);
|
|
}));
|
|
return socket;
|
|
}
|
|
|
|
getSocket((socket) => {
|
|
socket.on('error', common.mustCall((err) => {
|
|
socket.close();
|
|
assert.strictEqual(err, mockError);
|
|
}));
|
|
|
|
socket.send('foo', socket.address().port, 'localhost');
|
|
});
|
|
|
|
getSocket((socket) => {
|
|
const callback = common.mustCall((err) => {
|
|
socket.close();
|
|
assert.strictEqual(err, mockError);
|
|
});
|
|
|
|
socket.send('foo', socket.address().port, 'localhost', callback);
|
|
});
|
|
|
|
{
|
|
const socket = dgram.createSocket('udp4');
|
|
|
|
socket.on('message', common.mustNotCall('Should not receive any messages.'));
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
const port = socket.address().port;
|
|
const callback = common.mustCall((err) => {
|
|
socket.close();
|
|
assert.strictEqual(err.code, 'UNKNOWN');
|
|
assert.strictEqual(getSystemErrorName(err.errno), 'UNKNOWN');
|
|
assert.strictEqual(err.syscall, 'send');
|
|
assert.strictEqual(err.address, common.localhostIPv4);
|
|
assert.strictEqual(err.port, port);
|
|
assert.strictEqual(
|
|
err.message,
|
|
`${err.syscall} ${err.code} ${err.address}:${err.port}`
|
|
);
|
|
});
|
|
|
|
socket[kStateSymbol].handle.send = function() {
|
|
return UV_UNKNOWN;
|
|
};
|
|
|
|
socket.send('foo', port, common.localhostIPv4, callback);
|
|
}));
|
|
}
|