mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
57 lines
1.3 KiB
JavaScript
57 lines
1.3 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
if (common.isWindows)
|
|
common.skip('Does not support binding fd on Windows');
|
|
|
|
const dgram = require('dgram');
|
|
const assert = require('assert');
|
|
const { kStateSymbol } = require('internal/dgram');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const { TCP, constants } = internalBinding('tcp_wrap');
|
|
const TYPE = 'udp4';
|
|
|
|
// Throw when the fd is occupied according to https://github.com/libuv/libuv/pull/1851.
|
|
{
|
|
const socket = dgram.createSocket(TYPE);
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
const anotherSocket = dgram.createSocket(TYPE);
|
|
const { handle } = socket[kStateSymbol];
|
|
|
|
assert.throws(() => {
|
|
anotherSocket.bind({
|
|
fd: handle.fd,
|
|
});
|
|
}, {
|
|
code: 'EEXIST',
|
|
name: 'Error',
|
|
message: /^open EEXIST$/
|
|
});
|
|
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
// Throw when the type of fd is not "UDP".
|
|
{
|
|
const handle = new TCP(constants.SOCKET);
|
|
handle.listen();
|
|
|
|
const fd = handle.fd;
|
|
assert.notStrictEqual(fd, -1);
|
|
|
|
const socket = new dgram.createSocket(TYPE);
|
|
assert.throws(() => {
|
|
socket.bind({
|
|
fd,
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_FD_TYPE',
|
|
name: 'TypeError',
|
|
message: /^Unsupported fd type: TCP$/
|
|
});
|
|
|
|
handle.close();
|
|
}
|