mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
78 lines
2.4 KiB
JavaScript
78 lines
2.4 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { spawn } = require('child_process');
|
|
|
|
// Test stdio piping.
|
|
{
|
|
const child = spawn(...common.pwdCommand, { stdio: ['pipe'] });
|
|
assert.notStrictEqual(child.stdout, null);
|
|
assert.notStrictEqual(child.stderr, null);
|
|
}
|
|
|
|
// Test stdio ignoring.
|
|
{
|
|
const child = spawn(...common.pwdCommand, { stdio: 'ignore' });
|
|
assert.strictEqual(child.stdout, null);
|
|
assert.strictEqual(child.stderr, null);
|
|
}
|
|
|
|
// Asset options invariance.
|
|
{
|
|
const options = { stdio: 'ignore' };
|
|
spawn(...common.pwdCommand, options);
|
|
assert.deepStrictEqual(options, { stdio: 'ignore' });
|
|
}
|
|
|
|
// Test stdout buffering.
|
|
{
|
|
let output = '';
|
|
const child = spawn(...common.pwdCommand);
|
|
|
|
child.stdout.setEncoding('utf8');
|
|
child.stdout.on('data', function(s) {
|
|
output += s;
|
|
});
|
|
|
|
child.on('exit', common.mustCall(function(code) {
|
|
assert.strictEqual(code, 0);
|
|
}));
|
|
|
|
child.on('close', common.mustCall(function() {
|
|
assert.strictEqual(output.length > 1, true);
|
|
assert.strictEqual(output[output.length - 1], '\n');
|
|
}));
|
|
}
|
|
|
|
// Assert only one IPC pipe allowed.
|
|
assert.throws(
|
|
() => {
|
|
spawn(
|
|
...common.pwdCommand,
|
|
{ stdio: ['pipe', 'pipe', 'pipe', 'ipc', 'ipc'] }
|
|
);
|
|
},
|
|
{ code: 'ERR_IPC_ONE_PIPE', name: 'Error' }
|
|
);
|