mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
dc43066ee9
Do the same thing we do for other streams, and retain a reference to the Buffer that was sent over IPC while the write request is active, so that it doesn’t get garbage collected while the data is still in flight. (This is a good example of why it’s a bad idea that we’re not re-using the general streams implementation for IPC and instead maintain separate usage of the low-level I/O primitives.) Fixes: https://github.com/nodejs/node/issues/34797 PR-URL: https://github.com/nodejs/node/pull/38728 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
28 lines
818 B
JavaScript
28 lines
818 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const child_process = require('child_process');
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/34797
|
|
const eightMB = 8 * 1024 * 1024;
|
|
|
|
if (process.argv[2] === 'child') {
|
|
for (let i = 0; i < 4; i++) {
|
|
process.send(new Uint8Array(eightMB).fill(i));
|
|
}
|
|
} else {
|
|
const child = child_process.spawn(process.execPath, [__filename, 'child'], {
|
|
stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
|
|
serialization: 'advanced'
|
|
});
|
|
const received = [];
|
|
child.on('message', common.mustCall((chunk) => {
|
|
assert.deepStrictEqual(chunk, new Uint8Array(eightMB).fill(chunk[0]));
|
|
|
|
received.push(chunk[0]);
|
|
if (received.length === 4) {
|
|
assert.deepStrictEqual(received, [0, 1, 2, 3]);
|
|
}
|
|
}, 4));
|
|
}
|