mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
873 B
JavaScript
38 lines
873 B
JavaScript
'use strict';
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/13237
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
if (!common.isMainThread)
|
|
common.skip('Worker bootstrapping works differently -> different timing');
|
|
|
|
const async_hooks = require('async_hooks');
|
|
|
|
const seenEvents = [];
|
|
|
|
const p = new Promise((resolve) => resolve(1));
|
|
p.then(() => seenEvents.push('then'));
|
|
|
|
const hooks = async_hooks.createHook({
|
|
init: common.mustNotCall(),
|
|
|
|
before: common.mustCall((id) => {
|
|
assert.ok(id > 1);
|
|
seenEvents.push('before');
|
|
}),
|
|
|
|
after: common.mustCall((id) => {
|
|
assert.ok(id > 1);
|
|
seenEvents.push('after');
|
|
hooks.disable();
|
|
})
|
|
});
|
|
|
|
setImmediate(() => {
|
|
assert.deepStrictEqual(seenEvents, ['before', 'then', 'after']);
|
|
});
|
|
|
|
hooks.enable(); // After `setImmediate` in order to not catch its init event.
|