mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
a172397237
The new JS PromiseHooks introduced in the referenced PR are per v8::Context. This meant that code depending on them, such as AsyncLocalStorage, wouldn't behave correctly across vm.Context instances. PromiseHooks are now synchronized across the main Context and any Context created via vm.Context. Refs: https://github.com/nodejs/node/pull/36394 Fixes: https://github.com/nodejs/node/issues/38781 Signed-off-by: Bryan English <bryan@bryanenglish.com> PR-URL: https://github.com/nodejs/node/pull/38821 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
36 lines
880 B
JavaScript
36 lines
880 B
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
const { AsyncLocalStorage } = require('async_hooks');
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/38781
|
|
|
|
const context = vm.createContext({
|
|
AsyncLocalStorage,
|
|
assert
|
|
});
|
|
|
|
vm.runInContext(`
|
|
const storage = new AsyncLocalStorage()
|
|
async function test() {
|
|
return storage.run({ test: 'vm' }, async () => {
|
|
assert.strictEqual(storage.getStore().test, 'vm');
|
|
await 42;
|
|
assert.strictEqual(storage.getStore().test, 'vm');
|
|
});
|
|
}
|
|
test()
|
|
`, context);
|
|
|
|
const storage = new AsyncLocalStorage();
|
|
async function test() {
|
|
return storage.run({ test: 'main context' }, async () => {
|
|
assert.strictEqual(storage.getStore().test, 'main context');
|
|
await 42;
|
|
assert.strictEqual(storage.getStore().test, 'main context');
|
|
});
|
|
}
|
|
test();
|