mirror of
https://github.com/nodejs/node.git
synced 2024-11-24 20:29:23 +01:00
8b2011a818
V8 and Node.js had defined `NOMINMAX` on Windows for a long time. In recent changes, V8 added `std::numeric_limits::min` usages in its header files which caused addons without `NOMINMAX` defines failed to compile. Define `NOMINMAX` in common.gypi so that addons can be compiled with the latest V8 header files. PR-URL: https://github.com/nodejs/node/pull/52794 Fixes: https://github.com/nodejs/nan/issues/968 Refs: https://github.com/nodejs/gyp-next/pull/244 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
17 lines
654 B
JavaScript
17 lines
654 B
JavaScript
'use strict';
|
|
const common = require('../../common');
|
|
const assert = require('assert');
|
|
const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
|
|
const binding = require(bindingPath);
|
|
assert.strictEqual(binding.hello(), 'world');
|
|
console.log('binding.hello() =', binding.hello());
|
|
|
|
const binding2 = require(require.resolve(`./build/${common.buildType}/binding2`));
|
|
assert.strictEqual(binding2.hello(), 'world');
|
|
|
|
// Test multiple loading of the same module.
|
|
delete require.cache[bindingPath];
|
|
const rebinding = require(bindingPath);
|
|
assert.strictEqual(rebinding.hello(), 'world');
|
|
assert.notStrictEqual(binding.hello, rebinding.hello);
|