4 Commits

Author	SHA1	Message	Date
ZYSzys	dcc5e51e1c	tools: force common be required before any other modules ... PR-URL: https://github.com/nodejs/node/pull/27650 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	2019-05-13 19:39:34 +08:00
Michaël Zasso	fddcd6253b	test: move ESM fixtures to fixtures dir ... Also consistently import the `common` module where possible. PR-URL: https://github.com/nodejs/node/pull/19409 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Richard Lau <riclau@uk.ibm.com>	2018-03-21 20:08:30 +01:00
Gus Caplan	6934792eb3	lint: move eslint to new plugin system ... PR-URL: https://github.com/nodejs/node/pull/18566 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>	2018-02-20 13:13:22 -06:00
guybedford	d853758a22	module: fix hook module CJS dependency loading ... It can be useful to load dependencies as part of the loader hook definition file. This fixes a bug where `import x from 'x'` would always return `x` as `undefined` if the import was made in a loader hooks definition module. A parallel change to the CJS loading injection process meant that the CJS module wasn't being injected into the correct loader instance, which is corrected here with a test. PR-URL: https://github.com/nodejs/node/pull/16381 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	2017-10-28 13:22:55 +02:00