4 Commits

Author	SHA1	Message	Date
Ruben Bridgewater	50dd555910	doc,lib,test: capitalize comment sentences ... This activates the eslint capitalize comment rule for comments above 50 characters. PR-URL: https://github.com/nodejs/node/pull/24996 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2018-12-17 17:14:35 +01:00
cjihrig	df073cdda4	tty: make process.binding('tty_wrap') internal ... PR-URL: https://github.com/nodejs/node/pull/22477 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>	2018-08-29 12:28:51 -04:00
Daniel Bevenius	da8641f3b4	src: move process.binding('async_wrap') internal ... This commit makes the async_wrap builtin an internal builtin, and changes usage of the builtin from using process.binding('async_wrap') to use internalBinding instead. Refs: https://github.com/nodejs/node/issues/22160 PR-URL: https://github.com/nodejs/node/pull/22469 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>	2018-08-27 05:42:55 +02:00
Jeremiah Senkpiel	0a26280388	test: really test the ttywrap bits of getasyncid ... Follow-up from https://github.com/nodejs/node/pull/18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: https://github.com/nodejs/node/pull/18886 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	2018-02-22 12:12:41 -05:00