0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 07:27:22 +01:00
Commit Graph

9 Commits

Author SHA1 Message Date
Jeremiah Senkpiel
1db31a3494 doc: minor rewording to the GitHub issue/pr templates
- Templates are now a bit more consistent with phrasing.
- Simplified a bit.

PR-URL: https://github.com/nodejs/node/pull/7403
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-27 09:48:02 +02:00
Rich Trott
47b9b14574 doc: make pull request template more concise
PR-URL: https://github.com/nodejs/node/pull/7239
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
2016-06-10 21:57:20 -07:00
Rich Trott
0155744024
doc: consolidate test/lint text in GH PR template
PR-URL: https://github.com/nodejs/node/pull/7155
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2016-06-06 22:55:19 -04:00
Rich Trott
e350deb1e3 doc: edit pull request template
Move checklist instructions closer to the checklist. Trim unnecessary
words.

PR-URL: https://github.com/nodejs/node/pull/7058
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-01 19:46:10 -07:00
Rich Trott
b6a646dc8a doc: reduce GitHub template verbosity
Reduce unnecessarily verbose paragraph to a sentence.

PR-URL: https://github.com/nodejs/node/pull/6801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-05-19 22:12:23 -07:00
Rich Trott
42ede93d14 doc: trim GitHub template comments
Make the comments in the GitHub templates slightly more concise.

PR-URL: https://github.com/nodejs/node/pull/6755
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
2016-05-16 22:12:46 -07:00
Johan Bergström
b743d82ffc doc: improve github templates by using comments
Use HTML comments to reduce potential noise in github templates.
Also, improve flow of the pull request, making it easier to read.

PR-URL: https://github.com/nodejs/node/pull/5710
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
2016-04-06 09:20:02 +10:00
Fedor Indutny
4bd8b20f20 github: put description of PR to the end of tmpl
It looks like github appends commit log right after the template
contents. Seeing this it does not look logical to ask for details first.

This commit puts `Description of change` part to the end of the
template.

PR-URL: https://github.com/nodejs/node/pull/5378
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2016-02-23 19:20:48 -05:00
Fedor Indutny
81e35b5a29 github: add issue and pull request templates
Fix: #5246
PR-URL: https://github.com/nodejs/node/pull/5291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-23 00:36:45 -05:00