0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 23:43:09 +01:00
Commit Graph

2 Commits

Author SHA1 Message Date
Benjamin Ki
7294897c77 test: use common.PORT instead of an extraneous variable
This test is not parallelized and so we can use the test commons PORT
variable.

Refs: https://github.com/nodejs/node/pull/27565#discussion_r281000162

PR-URL: https://github.com/nodejs/node/pull/27565
Fixes: https://github.com/nodejs/node/issues/27341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-05-13 14:26:40 -07:00
Benjamin Ki
402a793012 test: move dgram invalid host test to internet tests
This moves a dgram test from `parallel` to `internet` because it relies
on a DNS request.
In certain cases, ISPs hijack invalid IETF-reserved invalid names which
causes a false negative failure.

Fixes: https://github.com/nodejs/node/issues/27341

PR-URL: https://github.com/nodejs/node/pull/27565
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-05-13 14:26:38 -07:00