0
0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Commit Graph

6 Commits

Author SHA1 Message Date
Rich Trott
b180a5beca doc: update Reviewing section of onboarding doc
PR-URL; https://github.com/nodejs/node/pull/8086
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
2016-08-15 22:08:52 -07:00
Rich Trott
ca6363b8ae doc: minor updates to onboarding doc
PR-URL: https://github.com/nodejs/node/pull/8060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2016-08-12 14:09:51 -07:00
Rich Trott
fa1476cb50 doc: add POST_STATUS_TO_PR info to onboarding doc
`POST_STATUS_TO_PR` previously did not work.

Now it works.

Update the onboarding documentation accordingly.

PR-URL: https://github.com/nodejs/node/pull/8059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2016-08-12 14:02:28 -07:00
Bryan English
5d6d3ee5fb doc: clarify "Reviewed-By" iff "LGTM"
As per conversation with @Trott, make it clear that Reviewed-By lines
should only be added for collaborators who've actually put a LGTM on the
PR.

PR-URL: https://github.com/nodejs/node/pull/7183
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: JacksonTian - Jackson Tian <shvyo1987@gmail.com>
2016-08-05 13:47:56 -07:00
Rich Trott
f3971ff117 doc: update labels and CI info in onboarding doc
PR-URL: https://github.com/nodejs/node/pull/7006
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2016-05-29 19:26:59 -07:00
Jeremiah Senkpiel
7a3ed98229 doc: add onboarding resources
PR-URL: https://github.com/nodejs/node/pull/3726
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2016-03-14 11:35:04 -04:00