From fba06eb34a23188329211a1eb540ac91865b4748 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 12 Aug 2024 15:20:55 +0200 Subject: [PATCH] deps: remove bogus V8 DCHECK Refs: https://github.com/nodejs/node/pull/54077#issuecomment-2283753739 PR-URL: https://github.com/nodejs/node/pull/54077 Reviewed-By: Jiawen Geng Reviewed-By: Richard Lau Reviewed-By: Joyee Cheung Reviewed-By: Marco Ippolito --- common.gypi | 2 +- deps/v8/src/ast/scopes.cc | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index a6a79adcc2f..c72fd626503 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.12', + 'v8_embedder_string': '-node.13', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/ast/scopes.cc b/deps/v8/src/ast/scopes.cc index d3245c3c912..eef58fe37ec 100644 --- a/deps/v8/src/ast/scopes.cc +++ b/deps/v8/src/ast/scopes.cc @@ -2714,7 +2714,6 @@ void Scope::AllocateScopeInfosRecursively( // Allocate ScopeInfos for inner scopes. for (Scope* scope = inner_scope_; scope != nullptr; scope = scope->sibling_) { - DCHECK_GT(scope->UniqueIdInScript(), UniqueIdInScript()); DCHECK_IMPLIES(scope->sibling_, scope->sibling_->UniqueIdInScript() != scope->UniqueIdInScript()); if (!scope->is_function_scope() ||