From f626acc328756fb37c5f32fa375adb6f400f63f1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
Date: Mon, 11 Mar 2024 10:30:53 +0000
Subject: [PATCH] deps: silence internal V8 deprecation warning

PR-URL: https://github.com/nodejs/node/pull/52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
---
 common.gypi                 | 2 +-
 deps/v8/src/base/optional.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common.gypi b/common.gypi
index bd91c2692f7..f2d3ed4730f 100644
--- a/common.gypi
+++ b/common.gypi
@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.4',
+    'v8_embedder_string': '-node.5',
 
     ##### V8 defaults for Node.js #####
 
diff --git a/deps/v8/src/base/optional.h b/deps/v8/src/base/optional.h
index 6ad1b6f7429..26ce8384429 100644
--- a/deps/v8/src/base/optional.h
+++ b/deps/v8/src/base/optional.h
@@ -16,7 +16,7 @@ namespace base {
 
 // These aliases are deprecated, use std::optional directly.
 template <typename T>
-using Optional [[deprecated]] = std::optional<T>;
+using Optional = std::optional<T>;
 
 using std::in_place;
 using std::make_optional;