From f057c7049eea6e6396dfd8117910ccb2a5c8977a Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Tue, 7 Jan 2014 17:51:41 +0100
Subject: [PATCH] build: unconditionally disable -Werror

Forcibly disable -Werror, the old { 'werror': '' } hack in node.gyp
no longer works with newer versions of V8.

We support a wide range of compilers, it's simply not feasible to
squelch all warnings, never mind that the libraries in deps/ are
not under our control.

Fixes #6817.
---
 common.gypi | 4 ++++
 node.gyp    | 3 ---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/common.gypi b/common.gypi
index 7e1e99969f4..e25e0cc7f60 100644
--- a/common.gypi
+++ b/common.gypi
@@ -103,6 +103,10 @@
         },
       }
     },
+    # Forcibly disable -Werror.  We support a wide range of compilers, it's
+    # simply not feasible to squelch all warnings, never mind that the
+    # libraries in deps/ are not under our control.
+    'cflags!': ['-Werror'],
     'msvs_settings': {
       'VCCLCompilerTool': {
         'StringPooling': 'true', # pool string literals
diff --git a/node.gyp b/node.gyp
index 0b5ea215b45..4a63faf4e1a 100644
--- a/node.gyp
+++ b/node.gyp
@@ -1,9 +1,6 @@
 {
   'variables': {
     'v8_use_snapshot%': 'true',
-    # Turn off -Werror in V8
-    # See http://codereview.chromium.org/8159015
-    'werror': '',
     'node_use_dtrace%': 'false',
     'node_use_etw%': 'false',
     'node_use_perfctr%': 'false',