mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

process: move --help and --bash-completeion handling to startExecution

Browse Source 
Because they are similar to `--prof-process` and are part of
the execution instead of initialization.
Also move the `getOptionValue` initialization to top scope since
it's used everywhere and add comments about the flags.

PR-URL: https://github.com/nodejs/node/pull/25262
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Joyee Cheung 2018-12-29 11:16:01 +08:00
parent 0878b6172e
commit ee12607c1c
No known key found for this signature in database
GPG Key ID: 92B78A53C8303B8D
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/internal/bootstrap/node.js
View File

@ -18,7 +18,7 @@
const { internalBinding, NativeModule } = loaderExports; const { internalBinding, NativeModule } = loaderExports;
let getOptionValue; const { getOptionValue } = NativeModule.require('internal/options');
function startup() { function startup() {
setupTraceCategoryState(); setupTraceCategoryState();
@ -168,18 +168,6 @@ function startup() {
NativeModule.require('internal/inspector_async_hook').setup(); NativeModule.require('internal/inspector_async_hook').setup();
} }
getOptionValue = NativeModule.require('internal/options').getOptionValue;
if (getOptionValue('--help')) {
NativeModule.require('internal/print_help').print(process.stdout);
return;
}
if (getOptionValue('--completion-bash')) {
NativeModule.require('internal/bash_completion').print(process.stdout);
return;
}
// If the process is spawned with env NODE_CHANNEL_FD, it's probably // If the process is spawned with env NODE_CHANNEL_FD, it's probably
// spawned by our child_process module, then initialize IPC. // spawned by our child_process module, then initialize IPC.
// This attaches some internal event listeners and creates: // This attaches some internal event listeners and creates:
@ -360,6 +348,18 @@ function startExecution() {
return; return;
} }
// node --help
if (getOptionValue('--help')) {
NativeModule.require('internal/print_help').print(process.stdout);
return;
}
// e.g. node --completion-bash >> ~/.bashrc
if (getOptionValue('--completion-bash')) {
NativeModule.require('internal/bash_completion').print(process.stdout);
return;
}
// `node --prof-process` // `node --prof-process`
if (getOptionValue('--prof-process')) { if (getOptionValue('--prof-process')) {
NativeModule.require('internal/v8_prof_processor'); NativeModule.require('internal/v8_prof_processor');