From dfff61475eb2b31043947b914bdcabfae7a60c0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 6 Apr 2023 14:50:56 +0200 Subject: [PATCH] deps: disable V8 concurrent sparkplug compilation It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: https://github.com/nodejs/node/issues/47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: https://github.com/nodejs/node/pull/47450 Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli Reviewed-By: Michael Dawson Reviewed-By: Rich Trott Reviewed-By: James M Snell PR-URL: https://github.com/nodejs/node/pull/54536 Reviewed-By: Antoine du Hamel Reviewed-By: Jiawen Geng Reviewed-By: Marco Ippolito --- common.gypi | 2 +- deps/v8/src/flags/flag-definitions.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 2acceb0f012..718b9dc24fd 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.1', + 'v8_embedder_string': '-node.2', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/flags/flag-definitions.h b/deps/v8/src/flags/flag-definitions.h index 0795dc0a83c..02f367e1126 100644 --- a/deps/v8/src/flags/flag-definitions.h +++ b/deps/v8/src/flags/flag-definitions.h @@ -1009,7 +1009,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code") DEFINE_BOOL_READONLY(concurrent_sparkplug, false, "compile Sparkplug code in a background thread") #else -DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT, +DEFINE_BOOL(concurrent_sparkplug, false, "compile Sparkplug code in a background thread") DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug) DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)