From cb34358dd9ceb0b2a7ddcf14120000cb060d8181 Mon Sep 17 00:00:00 2001 From: PerfectPan Date: Tue, 5 Nov 2019 15:08:42 +0800 Subject: [PATCH] assert: replace var with let in lib/assert.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs: https://github.com/nodejs/code-and-learn/issues/97 PR-URL: https://github.com/nodejs/node/pull/30261 Reviewed-By: Yongsheng Zhang Reviewed-By: Trivikram Kamat Reviewed-By: Gireesh Punathil Reviewed-By: Сковорода Никита Андреевич Reviewed-By: Colin Ihrig --- lib/assert.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/assert.js b/lib/assert.js index d307582d1fd..4ce3c3bfdef 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -186,7 +186,7 @@ function getCode(fd, line, column) { buffer = lines < line ? buffer : Buffer.allocUnsafe(bytesPerRead); bytesRead = readSync(fd, buffer, 0, bytesPerRead); // Read the buffer until the required code line is found. - for (var i = 0; i < bytesRead; i++) { + for (let i = 0; i < bytesRead; i++) { if (buffer[i] === 10 && ++lines === line) { // If the end of file is reached, directly parse the code and return. if (bytesRead < bytesPerRead) { @@ -863,7 +863,7 @@ assert.ifError = function ifError(err) { tmp2.shift(); // Filter all frames existing in err.stack. let tmp1 = newErr.stack.split('\n'); - for (var i = 0; i < tmp2.length; i++) { + for (let i = 0; i < tmp2.length; i++) { // Find the first occurrence of the frame. const pos = tmp1.indexOf(tmp2[i]); if (pos !== -1) {