mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

test: refactor test-cluster-disconnect

Browse Source 
Replace `process.once('exit', ...)` with `common.mustCall()`.
Remove unneeded variable in loop declaration.

PR-URL: https://github.com/nodejs/node/pull/11981
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Rich Trott 2017-03-21 21:48:21 -07:00
parent 9ff7ed23cd
commit a45c2db4b6
1 changed files with 8 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
test/parallel/test-cluster-disconnect.js
View File

@ -42,7 +42,7 @@ if (cluster.isWorker) {
const socket = net.connect(port, '127.0.0.1', () => {
// buffer result
let result = '';
socket.on('data', common.mustCall((chunk) => { result += chunk; }));
socket.on('data', (chunk) => { result += chunk; });
// check result
socket.on('end', common.mustCall(() => {
@ -55,7 +55,7 @@ if (cluster.isWorker) {
const testCluster = function(cb) {
let done = 0;
for (let i = 0, l = servers; i < l; i++) {
for (let i = 0; i < servers; i++) {
testConnection(common.PORT + i, (success) => {
assert.ok(success);
done += 1;
@ -81,40 +81,21 @@ if (cluster.isWorker) {
}
};
const results = {
start: 0,
test: 0,
disconnect: 0
};
const test = function(again) {
//1. start cluster
startCluster(() => {
results.start += 1;
startCluster(common.mustCall(() => {
//2. test cluster
testCluster(() => {
results.test += 1;
testCluster(common.mustCall(() => {
//3. disconnect cluster
cluster.disconnect(() => {
results.disconnect += 1;
cluster.disconnect(common.mustCall(() => {
// run test again to confirm cleanup
if (again) {
test();
}
});
});
});
}));
}));
}));
};
test(true);
process.once('exit', () => {
assert.strictEqual(results.start, 2);
assert.strictEqual(results.test, 2);
assert.strictEqual(results.disconnect, 2);
});
}