mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

tools: do not disable quotes rule in .eslintrc.js

Browse Source 
Re-enable `quotes` rule in .eslintrc.js and fix code to abide by the
rule. As a bonus, this makes the code (IMO, anyway) more readable. (It
certainly isn't *less* readable, at least not IMO.)

PR-URL: https://github.com/nodejs/node/pull/21338
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rich Trott 2018-06-14 20:43:49 -07:00
parent b6b019f37b
commit a13eba7e9f
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
.eslintrc.js
View File

@ -147,32 +147,32 @@ module.exports = {
message: '__defineSetter__ is deprecated.', message: '__defineSetter__ is deprecated.',
} }
], ],
/* eslint-disable max-len, quotes */ /* eslint-disable max-len */
// If this list is modified, please copy the change to lib/.eslintrc.yaml // If this list is modified, please copy the change to lib/.eslintrc.yaml
'no-restricted-syntax': [ 'no-restricted-syntax': [
'error', 'error',
{ {
selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']", selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead." message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.'
}, },
{ {
selector: `CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]`, selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]",
message: 'assert.rejects() must be invoked with at least two arguments.', message: 'assert.rejects() must be invoked with at least two arguments.',
}, },
{ {
selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`, selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
message: 'Use an object as second argument of assert.throws()', message: 'Use an object as second argument of assert.throws()',
}, },
{ {
selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]`, selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]",
message: 'assert.throws() must be invoked with at least two arguments.', message: 'assert.throws() must be invoked with at least two arguments.',
}, },
{ {
selector: `CallExpression[callee.name='setTimeout'][arguments.length<2]`, selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
message: 'setTimeout() must be invoked with at least two arguments.', message: 'setTimeout() must be invoked with at least two arguments.',
}, },
{ {
selector: `CallExpression[callee.name='setInterval'][arguments.length<2]`, selector: "CallExpression[callee.name='setInterval'][arguments.length<2]",
message: 'setInterval() must be invoked with at least 2 arguments.', message: 'setInterval() must be invoked with at least 2 arguments.',
}, },
{ {