mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

errors: remove needless lazyAssert

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/11891
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This commit is contained in:
DavidCai 2017-03-17 14:13:58 +08:00 committed by James M Snell
parent 757ff8071e
commit a00c9e95e4
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/internal/errors.js
View File

@ -6,16 +6,11 @@
// value statically and permanently identifies the error. While the error // value statically and permanently identifies the error. While the error
// message may change, the code should not. // message may change, the code should not.
const assert = require('assert');
const kCode = Symbol('code'); const kCode = Symbol('code');
const messages = new Map(); const messages = new Map();
var assert, util; var util;
function lazyAssert() {
if (!assert)
assert = require('assert');
return assert;
}
function lazyUtil() { function lazyUtil() {
if (!util) if (!util)
util = require('util'); util = require('util');
@ -41,7 +36,6 @@ function makeNodeError(Base) {
} }
function message(key, args) { function message(key, args) {
const assert = lazyAssert();
assert.strictEqual(typeof key, 'string'); assert.strictEqual(typeof key, 'string');
const util = lazyUtil(); const util = lazyUtil();
const msg = messages.get(key); const msg = messages.get(key);
@ -60,7 +54,6 @@ function message(key, args) {
// Utility function for registering the error codes. Only used here. Exported // Utility function for registering the error codes. Only used here. Exported
// *only* to allow for testing. // *only* to allow for testing.
function E(sym, val) { function E(sym, val) {
const assert = lazyAssert();
assert(messages.has(sym) === false, `Error symbol: ${sym} was already used.`); assert(messages.has(sym) === false, `Error symbol: ${sym} was already used.`);
messages.set(sym, typeof val === 'function' ? val : String(val)); messages.set(sym, typeof val === 'function' ? val : String(val));
} }