From 9dfa30bdd53e0c110106314f9d40a3889941bd72 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 3 Sep 2021 12:54:28 -0400 Subject: [PATCH] build: compile with C++17 (MSVC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/38807 Refs: https://github.com/nodejs/node/pull/38788 Reviewed-By: Antoine du Hamel Reviewed-By: Jiawen Geng Reviewed-By: James M Snell Reviewed-By: Juan José Arboleda Reviewed-By: Michaël Zasso Reviewed-By: Ash Cripps --- common.gypi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index c0427c25a02..505cacb938e 100644 --- a/common.gypi +++ b/common.gypi @@ -259,7 +259,10 @@ ], 'msvs_settings': { 'VCCLCompilerTool': { - 'AdditionalOptions': ['/Zc:__cplusplus'], + 'AdditionalOptions': [ + '/Zc:__cplusplus', + '-std:c++17' + ], 'BufferSecurityCheck': 'true', 'DebugInformationFormat': 1, # /Z7 embed info in .obj files 'ExceptionHandling': 0, # /EHsc