From 99797cc9cd2ead9d25330b263fca808477d55621 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 28 Feb 2019 08:35:03 +0100 Subject: [PATCH] build: make 'floating patch' message informational Downgrade the 'Using floating patch' message that is emitted when a local patch is applied to the bundled ICU from a warning to a notice. There isn't anything the user can or should do so warning isn't appropriate. Instead of angry yellow use soothing green. Fixes: https://github.com/nodejs/node/issues/26346 PR-URL: https://github.com/nodejs/node/pull/26349 Reviewed-By: Richard Lau Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Refael Ackermann --- configure.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.py b/configure.py index ac6b3d4788c..cd74f23a6c4 100755 --- a/configure.py +++ b/configure.py @@ -585,6 +585,10 @@ def warn(msg): # track if warnings occurred warn.warned = False +def info(msg): + prefix = '\033[1m\033[32mINFO\033[0m' if os.isatty(1) else 'INFO' + print('%s: %s' % (prefix, msg)) + def print_verbose(x): if not options.verbose: return @@ -1232,7 +1236,7 @@ def glob_to_var(dir_base, dir_sub, patch_dir): patchfile = '%s/%s/%s' % (dir_base, patch_dir, file) if os.path.isfile(patchfile): srcfile = '%s/%s' % (patch_dir, file) - warn('Using floating patch "%s" from "%s"' % (patchfile, dir_base)) + info('Using floating patch "%s" from "%s"' % (patchfile, dir_base)) list.append(srcfile) break return list