From 8a15f32d07c8fbb50528d37447ae296dd785f8eb Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Thu, 8 Sep 2022 19:52:10 +0200
Subject: [PATCH] Revert "build: go faster, drop -fno-omit-frame-pointer"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit d0f73d383d5e1ed58c96a272036744d4bed22b8f.

The lack of frame pointers unfortunately breaks the --perf_basic_prof
flag because perf(1) then no longer understands C++ <-> JS stack frame
transitions.

PR-URL: https://github.com/nodejs/node/pull/44566
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
---
 common.gypi | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/common.gypi b/common.gypi
index 2a8beb34c1c..3f708d89b1e 100644
--- a/common.gypi
+++ b/common.gypi
@@ -204,7 +204,6 @@
             ],
           }],
           ['OS=="solaris"', {
-           'cflags': [ '-fno-omit-frame-pointer' ],
             # pull in V8's postmortem metadata
             'ldflags': [ '-Wl,-z,allextract' ]
           }],
@@ -212,6 +211,12 @@
             # increase performance, number from experimentation
             'cflags': [ '-qINLINE=::150:100000' ]
           }],
+          ['OS!="mac" and OS!="win" and OS!="zos"', {
+            # -fno-omit-frame-pointer is necessary for the --perf_basic_prof
+            # flag to work correctly. perf(1) gets confused about JS stack
+            # frames otherwise, even with --call-graph dwarf.
+            'cflags': [ '-fno-omit-frame-pointer' ],
+          }],
           ['OS=="linux"', {
             'conditions': [
               ['enable_pgo_generate=="true"', {