From 762a440e68b1893c9b0478050d9a018cf285a9de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 27 Aug 2024 10:40:54 +0200 Subject: [PATCH] deps: patch V8 to support older Clang versions PR-URL: https://github.com/nodejs/node/pull/54536 Reviewed-By: Antoine du Hamel Reviewed-By: Jiawen Geng Reviewed-By: Marco Ippolito Reviewed-By: Richard Lau --- common.gypi | 2 +- deps/v8/src/compiler/turboshaft/assembler.h | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/common.gypi b/common.gypi index 74c4b120c11..af2f3d9cb1a 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.6', + 'v8_embedder_string': '-node.7', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/compiler/turboshaft/assembler.h b/deps/v8/src/compiler/turboshaft/assembler.h index 914e53ca4e1..0ca95e6cae6 100644 --- a/deps/v8/src/compiler/turboshaft/assembler.h +++ b/deps/v8/src/compiler/turboshaft/assembler.h @@ -5,6 +5,7 @@ #ifndef V8_COMPILER_TURBOSHAFT_ASSEMBLER_H_ #define V8_COMPILER_TURBOSHAFT_ASSEMBLER_H_ +#include #include #include #include @@ -197,8 +198,8 @@ template class IndexRange : public Range { public: using base = Range; - using value_type = base::value_type; - using iterator_type = base::iterator_type; + using value_type = typename base::value_type; + using iterator_type = typename base::iterator_type; explicit IndexRange(ConstOrV count) : Range(0, count, 1) {} }; @@ -226,8 +227,8 @@ class Sequence : private Range { using base = Range; public: - using value_type = base::value_type; - using iterator_type = base::iterator_type; + using value_type = typename base::value_type; + using iterator_type = typename base::iterator_type; explicit Sequence(ConstOrV begin, ConstOrV stride = 1) : base(begin, 0, stride) {} @@ -731,7 +732,7 @@ struct LoopLabelForHelper...>> { } // namespace detail template -using LoopLabelFor = detail::LoopLabelForHelper::type; +using LoopLabelFor = typename detail::LoopLabelForHelper::type; Handle BuiltinCodeHandle(Builtin builtin, Isolate* isolate);