mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

build: tidy up additional libraries on Windows

Browse Source 
The report functionality that depended on `Dbghelp.lib` and `Psapi.lib`
are actually in `src/debug_utils.cc` and are not dependent on the
report functionality being enabled.

PR-URL: https://github.com/nodejs/node/pull/27138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Richard Lau 2019-04-08 19:41:52 +01:00
parent 06c803d9b9
commit 72f4a830d7
1 changed files with 7 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
node.gyp
View File

@ -345,16 +345,7 @@
],
'conditions': [
['OS=="win"', {
'libraries': [
'dbghelp.lib',
'PsApi.lib',
'Ws2_32.lib',
],
'dll_files': [
'dbghelp.dll',
'PsApi.dll',
'Ws2_32.dll',
],
'libraries': [ 'Ws2_32' ],
}],
],
}],
@ -623,7 +614,10 @@
],
}],
],
'libraries': [ '-lpsapi.lib' ]
'libraries': [
'Dbghelp',
'Psapi',
],
}],
[ 'node_use_etw=="true"', {
'defines': [ 'HAVE_ETW=1' ],
@ -718,16 +712,7 @@
],
'conditions': [
['OS=="win"', {
'libraries': [
'dbghelp.lib',
'PsApi.lib',
'Ws2_32.lib',
],
'dll_files': [
'dbghelp.dll',
'PsApi.dll',
'Ws2_32.dll',
],
'libraries': [ 'Ws2_32' ],
}],
],
}],
@ -1083,16 +1068,7 @@
],
'conditions': [
['OS=="win"', {
'libraries': [
'dbghelp.lib',
'PsApi.lib',
'Ws2_32.lib',
],
'dll_files': [
'dbghelp.dll',
'PsApi.dll',
'Ws2_32.dll',
],
'libraries': [ 'Ws2_32' ],
}],
],
}],