mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

test: refactor test-readline-keys

Browse Source 
* replace `util._extend()` with `Object.assign()`
* extract repeated map function to a single instance
* remove unneeded truthiness-check ternary on Objects

PR-URL: https://github.com/nodejs/node/pull/11281
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-02-09 21:29:56 -08:00
parent dd1cf8bb37
commit 6dd979e67c
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/parallel/test-readline-keys.js
View File

@ -3,7 +3,6 @@ const common = require('../common');
const PassThrough = require('stream').PassThrough;
const assert = require('assert');
const inherits = require('util').inherits;
const extend = require('util')._extend;
const Interface = require('readline').Interface;
@ -12,6 +11,10 @@ function FakeInput() {
}
inherits(FakeInput, PassThrough);
function extend(k) {
return Object.assign({ ctrl: false, meta: false, shift: false }, k);
}
const fi = new FakeInput();
const fo = new FakeInput();
@ -32,9 +35,7 @@ function addTest(sequences, expectedKeys) {
expectedKeys = [ expectedKeys ];
}
expectedKeys = expectedKeys.map((k) => {
return k ? extend({ ctrl: false, meta: false, shift: false }, k) : k;
});
expectedKeys = expectedKeys.map(extend);
keys = [];
@ -65,9 +66,7 @@ const addKeyIntervalTest = (sequences, expectedKeys, interval = 550,
expectedKeys = [ expectedKeys ];
}
expectedKeys = expectedKeys.map((k) => {
return k ? extend({ ctrl: false, meta: false, shift: false }, k) : k;
});
expectedKeys = expectedKeys.map(extend);
const keys = [];
fi.on('keypress', (s, k) => keys.push(k));