From 628ae25795a8dc6851ffa5ebdd45d100df04a435 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 15 Apr 2016 21:19:21 +0200 Subject: [PATCH] test: make addon testing part of `make test` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Otherwise it's too easy to miss breaking changes to node.h and other public headers until the CI catches them. `vcbuild test` tests addons so there is precedence. PR-URL: https://github.com/nodejs/node/pull/6232 Reviewed-By: Johan Bergström --- Makefile | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 604def253e4..f3b90b9c4fb 100644 --- a/Makefile +++ b/Makefile @@ -114,9 +114,9 @@ v8: tools/make-v8.sh v8 $(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS) -test: | cctest # Depends on 'all'. +test: | build-addons cctest # Both targets depend on 'all'. $(PYTHON) tools/test.py --mode=release -J \ - doctool message parallel sequential + addon doctool message parallel sequential $(MAKE) lint test-parallel: all @@ -141,7 +141,10 @@ ADDONS_BINDING_GYPS := \ $(wildcard test/addons/*/binding.gyp)) # Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale. -test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp +test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) \ + deps/uv/include/*.h deps/v8/include/*.h \ + src/node.h src/node_buffer.h src/node_object_wrap.h \ + | test/addons/.docbuildstamp # Cannot use $(wildcard test/addons/*/) here, it's evaluated before # embedded addons have been generated from the documentation. for dirname in test/addons/*/; do \