0
0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00

Do not pause request for multipart parsing

This is actually undesireable as it takes away control from the user who
may want to pause/resume to throttle the upload stream, or synchronize
it with disk flushing.

I actually ran into memory issues when trying to stream huge files to
disc as the file module was building up a huge action buffer. This can
now easily be avoided like this:

part.addListener('body', function(chunk) {
  req.pause();
  file.write(chunk).addCallback(function() {
    req.resume();
  });
}
This commit is contained in:
Felix Geisendörfer 2009-12-20 20:27:06 +01:00 committed by Ryan Dahl
parent e6c5ac4f73
commit 5de04dafc6

View File

@ -53,11 +53,7 @@ proto.init = function(options) {
var self = this;
req
.addListener('body', function(chunk) {
req.pause();
self.write(chunk);
setTimeout(function() {
req.resume();
});
})
.addListener('complete', function() {
self.emit('complete');