mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

child_process: rename field _internal to _handle

Browse Source 
Consistent with how other classes that are built around HandleWraps call it.
This commit is contained in:
Ben Noordhuis 2012-04-27 16:52:06 +02:00
parent f66f793c07
commit 4ec77e2e28
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/child_process.js
View File

@ -627,8 +627,8 @@ function ChildProcess() {
this.exitCode = null;
this.killed = false;
this._internal = new Process();
this._internal.onexit = function(exitCode, signalCode) {
this._handle = new Process();
this._handle.onexit = function(exitCode, signalCode) {
//
// follow 0.4.x behaviour:
//
@ -645,8 +645,8 @@ function ChildProcess() {
self.stdin.destroy();
}
self._internal.close();
self._internal = null;
self._handle.close();
self._handle = null;
self.emit('exit', self.exitCode, self.signalCode);
@ -681,7 +681,7 @@ ChildProcess.prototype.spawn = function(options) {
setStreamOption('stdoutStream', 1, options);
setStreamOption('stderrStream', 2, options);
var r = this._internal.spawn(options);
var r = this._handle.spawn(options);
if (r) {
if (options.stdinStream) {
@ -696,12 +696,12 @@ ChildProcess.prototype.spawn = function(options) {
options.stderrStream.close();
}
this._internal.close();
this._internal = null;
this._handle.close();
this._handle = null;
throw errnoException(errno, 'spawn');
}
this.pid = this._internal.pid;
this.pid = this._handle.pid;
if (options.stdinStream) {
this.stdin = createSocket(options.stdinStream, false);
@ -754,9 +754,9 @@ ChildProcess.prototype.kill = function(sig) {
throw new Error('Unknown signal: ' + sig);
}
if (this._internal) {
if (this._handle) {
this.killed = true;
var r = this._internal.kill(signal);
var r = this._handle.kill(signal);
if (r === -1) {
this.emit('error', errnoException(errno, 'kill'));
return;

2
test/simple/test-child-process-kill-throw.js
View File

@ -30,7 +30,7 @@ if (process.argv[2] === 'child') {
var error = {};
child.on('exit', function() {
child._internal = {
child._handle = {
kill: function() {
global.errno = 42;
return -1;