From 40ef9d541ed79470977f90eb445c291b95ab75a0 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 26 Apr 2024 23:32:46 +0100 Subject: [PATCH] deps: V8: cherry-pick 500de8bd371b MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: [gcc] Fix gcc / bazel build Add includes to fix gcc/blaze builds. Also ignore a dangling pointer warning introduced in newer gcc, since it has false positives on some uses of scope classes. Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192 Auto-Submit: Leszek Swirski Reviewed-by: Adam Klein Reviewed-by: Michael Achenbach Commit-Queue: Michael Achenbach Cr-Commit-Position: refs/heads/main@{#92977} Refs: https://github.com/v8/v8/commit/500de8bd371b224bb5274e88d6c7b165a146d378 PR-URL: https://github.com/nodejs/node/pull/52676 Fixes: https://github.com/nodejs/node/issues/52675 Reviewed-By: Yagiz Nizipli Reviewed-By: Jiawen Geng Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Moshe Atlow Reviewed-By: Gerhard Stöbich --- common.gypi | 2 +- deps/v8/BUILD.gn | 4 ++++ deps/v8/src/compiler/turboshaft/assembler.h | 1 + deps/v8/src/wasm/wasm-disassembler.cc | 2 ++ 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index e2b8476f332..da9076c0044 100644 --- a/common.gypi +++ b/common.gypi @@ -37,7 +37,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/BUILD.gn b/deps/v8/BUILD.gn index a25b6f2ac98..e2e0c16d970 100644 --- a/deps/v8/BUILD.gn +++ b/deps/v8/BUILD.gn @@ -1716,6 +1716,10 @@ config("toolchain") { # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108517 "-Wno-nonnull", + + # Disable dangling pointer warnings, which are often false positives when + # using scopes. + "-Wno-dangling-pointer", ] } diff --git a/deps/v8/src/compiler/turboshaft/assembler.h b/deps/v8/src/compiler/turboshaft/assembler.h index e324c82b08c..8493aca79dd 100644 --- a/deps/v8/src/compiler/turboshaft/assembler.h +++ b/deps/v8/src/compiler/turboshaft/assembler.h @@ -6,6 +6,7 @@ #define V8_COMPILER_TURBOSHAFT_ASSEMBLER_H_ #include +#include #include #include #include diff --git a/deps/v8/src/wasm/wasm-disassembler.cc b/deps/v8/src/wasm/wasm-disassembler.cc index 6c5da414047..1690ca026e7 100644 --- a/deps/v8/src/wasm/wasm-disassembler.cc +++ b/deps/v8/src/wasm/wasm-disassembler.cc @@ -4,6 +4,8 @@ #include "src/wasm/wasm-disassembler.h" +#include + #include "src/debug/debug-interface.h" #include "src/numbers/conversions.h" #include "src/wasm/module-decoder-impl.h"