From 400df22c6bfefc3c3f54ebd7c5fd0d38f5137841 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 8 Jun 2018 09:48:48 -0700 Subject: [PATCH] =?UTF-8?q?tools:=20update=20tooling=20to=20work=20with=20?= =?UTF-8?q?new=20macOS=20CLI=20=E2=80=A6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using High Sierra and `xcode-select --install` without installing full Xcode, our build tooling breaks due to faulty regular expressions. Update the `configure` script in our project root directory to handle multi-digit version numbers. `tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be updated for a complete fix. PR-URL: https://github.com/nodejs/node/pull/21173 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Refael Ackermann Reviewed-By: James M Snell --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index db9c45a868f..5e365914d84 100755 --- a/configure +++ b/configure @@ -667,7 +667,7 @@ def get_llvm_version(cc): def get_xcode_version(cc): return get_version_helper( - cc, r"(^Apple LLVM version) ([5-9]\.[0-9]+)") + cc, r"(^Apple LLVM version) ([0-9]+\.[0-9]+)") def get_gas_version(cc): try: