From 3fa5d80edae000eb280aa9c715ac9245e3b98e06 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Tue, 9 May 2017 17:06:07 +0800 Subject: [PATCH] benchmark: chunky http client should exit with 0 Previously when there is an error in the chunky client of the http benchmark, the server would not check the exit code and thus produce invalid results. PR-URL: https://github.com/nodejs/node/pull/12916 Fixes: https://github.com/nodejs/node/issues/12903 Reviewed-By: Vse Mozhet Byt Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- benchmark/http/http_server_for_chunky_client.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/benchmark/http/http_server_for_chunky_client.js b/benchmark/http/http_server_for_chunky_client.js index 3b0ec21cbe3..04d5a2c4a02 100644 --- a/benchmark/http/http_server_for_chunky_client.js +++ b/benchmark/http/http_server_for_chunky_client.js @@ -1,5 +1,6 @@ 'use strict'; +var assert = require('assert'); var path = require('path'); var http = require('http'); var fs = require('fs'); @@ -37,6 +38,7 @@ server.listen(PIPE); var child = fork(pep, process.argv.slice(2)); child.on('message', common.sendResult); -child.on('close', function() { +child.on('close', function(code) { server.close(); + assert.strictEqual(code, 0); });