mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

test: add missing tmpdir.refresh() in recently-added test

Browse Source 
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: https://github.com/nodejs/node/pull/24913#issuecomment-447982921

PR-URL: https://github.com/nodejs/node/pull/25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This commit is contained in:
Rich Trott 2018-12-17 13:42:46 -08:00
parent 3b2698e41f
commit 3ccb900e0c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-child-process-spawn-args.js
View File

@ -12,6 +12,8 @@ const { spawn } = require('child_process');
const common = require('../common');
const tmpdir = require('../common/tmpdir');
tmpdir.refresh();
const command = common.isWindows ? 'cd' : 'pwd';
const options = { cwd: tmpdir.path };