0
0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00

build: do not depend on cp in PATH

Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: https://github.com/nodejs/node/issues/20272

PR-URL: https://github.com/nodejs/node/pull/20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anna Henningsen 2018-04-25 18:10:38 +02:00
parent 6c6f31392c
commit 2b8512738a
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9

View File

@ -682,13 +682,13 @@
'toolsets': ['host'],
'conditions': [
[ 'v8_enable_inspector==1', {
'actions': [
'copies': [
{
'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder',
'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ],
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ],
'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ],
},
'destination': '<(SHARED_INTERMEDIATE_DIR)',
'files': ['deps/v8/src/inspector/js_protocol.pdl']
}
],
'actions': [
{
'action_name': 'v8_inspector_convert_protocol_to_json',
'inputs': [