mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 21:19:50 +01:00
Code Issues Releases Activity

build: turn on custom V8 snapshot by default

Browse Source 
This patch re-enables custom V8 snapshot integration. Also renames
the experimental configure switch from `--with-node-snapshot`
to `--without-node-snapshot` to be consistent with`--without-snapshot`
which is used for the default V8 snapshot.

PR-URL: https://github.com/nodejs/node/pull/28181
Refs: https://github.com/nodejs/node/pull/27365
Refs: https://github.com/nodejs/node/issues/17058
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Joyee Cheung 2019-06-12 02:38:14 +08:00
parent b6e41f0602
commit 28d3f1963a
No known key found for this signature in database
GPG Key ID: 92B78A53C8303B8D
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
configure.py
View File

@ -421,10 +421,10 @@ parser.add_option('--with-ltcg',
dest='with_ltcg',
help='Use Link Time Code Generation. This feature is only available on Windows.')
parser.add_option('--with-node-snapshot',
parser.add_option('--without-node-snapshot',
action='store_true',
dest='with_node_snapshot',
help='Turn on V8 snapshot integration. Currently experimental.')
dest='without_node_snapshot',
help='Turn off V8 snapshot integration. Currently experimental.')
intl_optgroup.add_option('--download',
action='store',
@ -942,11 +942,9 @@ def configure_node(o):
o['variables']['want_separate_host_toolset'] = int(
cross_compiling and want_snapshots)
if options.with_node_snapshot:
o['variables']['node_use_node_snapshot'] = 'true'
if not options.without_node_snapshot:
o['variables']['node_use_node_snapshot'] = b(not cross_compiling)
else:
# Default to false for now.
# TODO(joyeecheung): enable it once we fix the hashseed uniqueness
o['variables']['node_use_node_snapshot'] = 'false'
if target_arch == 'arm':