From 2068c4083bd8672175a434bc0774d1be72a284a5 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Mon, 24 Jun 2024 14:05:56 +0100 Subject: [PATCH] tools: fix skip detection of test runner output Fix the Python test harness so that it no longer treats the `# skipped` part of the summary at the end of the built-in test runner output as marking the test as skipped. PR-URL: https://github.com/nodejs/node/pull/53545 Fixes: https://github.com/nodejs/node/issues/50346 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Chemi Atlow Reviewed-By: Moshe Atlow --- tools/test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test.py b/tools/test.py index af88bc55cc0..9d7838d7c01 100755 --- a/tools/test.py +++ b/tools/test.py @@ -83,7 +83,7 @@ except ImportError: logger = logging.getLogger('testrunner') -skip_regex = re.compile(r'# SKIP\S*\s+(.*)', re.IGNORECASE) +skip_regex = re.compile(r'(?:\d+\.\.\d+|ok|not ok).*# SKIP\S*\s+(.*)', re.IGNORECASE) VERBOSE = False