mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
test: avoid usage of mixed IPV6 addresses
The test case fails in AIX due to the mixed-use of unspecified and loopback addresses. This is not a problem in most platforms but fails in AIX. (In Windows too, but does not manifest as the test is omitted in Windows for a different reason). There exists no documented evidence which supports the mixed use of unspecified and loopback addresses. While AIX strictly follows the IPV6 specification with respect to unspecified address ('::') and loopback address ('::1'), the test case latches on to the behavior exhibited by other platforms, and hence it fails in AIX. The proposed fix is to make it work in all platforms including AIX by using the loopback address for the client to connect, as that is the address at which the server listens. Fixes: https://github.com/nodejs/node/issues/7563 PR-URL: https://github.com/nodejs/node/pull/7702 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
parent
04b4d15b39
commit
17883dfaaf
@ -92,7 +92,7 @@ if (cluster.isMaster) {
|
||||
debugger;
|
||||
};
|
||||
if (common.hasIPv6)
|
||||
server.listen(cb);
|
||||
server.listen(0, '::1', cb);
|
||||
else
|
||||
server.listen(0, common.localhostIPv4, cb);
|
||||
process.on('disconnect', process.exit);
|
||||
|
Loading…
Reference in New Issue
Block a user