mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
Code Issues Releases Activity

test: improve code in test-fs-open.js

Browse Source 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use assert.strictEqual instead of assert.ok
* use assert.ifError

PR-URL: https://github.com/nodejs/node/pull/10312
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit is contained in:
Adrian Estrada 2016-12-17 18:10:57 -05:00 committed by Italo A. Casas
parent a308a2fae4
commit 15c71f6c66
1 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/parallel/test-fs-open.js
View File

@ -1,27 +1,24 @@
'use strict';
const common = require('../common');
var assert = require('assert');
var fs = require('fs');
const assert = require('assert');
const fs = require('fs');
let caughtException = false;
var caughtException = false;
try {
// should throw ENOENT, not EBADF
// see https://github.com/joyent/node/pull/1228
fs.openSync('/path/to/file/that/does/not/exist', 'r');
} catch (e) {
assert.equal(e.code, 'ENOENT');
assert.strictEqual(e.code, 'ENOENT');
caughtException = true;
}
assert.ok(caughtException);
assert.strictEqual(caughtException, true);
fs.open(__filename, 'r', common.mustCall(function(err, fd) {
if (err) {
throw err;
}
fs.open(__filename, 'r', common.mustCall((err) => {
assert.ifError(err);
}));
fs.open(__filename, 'rs', common.mustCall(function(err, fd) {
if (err) {
throw err;
}
fs.open(__filename, 'rs', common.mustCall((err) => {
assert.ifError(err);
}));