diff --git a/lib/internal/perf/performance.js b/lib/internal/perf/performance.js index 836dcaa87d8..9e08bc5db7e 100644 --- a/lib/internal/perf/performance.js +++ b/lib/internal/perf/performance.js @@ -97,13 +97,16 @@ class Performance extends EventTarget { return filterBufferMapByNameAndType(); } - getEntriesByName(name) { + getEntriesByName(name, type = undefined) { validateInternalField(this, kPerformanceBrand, 'Performance'); if (arguments.length === 0) { throw new ERR_MISSING_ARGS('name'); } name = `${name}`; - return filterBufferMapByNameAndType(name, undefined); + if (type !== undefined) { + type = `${type}`; + } + return filterBufferMapByNameAndType(name, type); } getEntriesByType(type) { diff --git a/test/parallel/test-performance-timeline.mjs b/test/parallel/test-performance-timeline.mjs index 57e0f6f0b7b..e3af49447c8 100644 --- a/test/parallel/test-performance-timeline.mjs +++ b/test/parallel/test-performance-timeline.mjs @@ -33,6 +33,12 @@ await setTimeout(50); performance.measure('a', 'one'); const entriesByName = performance.getEntriesByName('a'); assert.deepStrictEqual(entriesByName.map((x) => x.entryType), ['measure', 'mark', 'measure', 'mark']); +const marksByName = performance.getEntriesByName('a', 'mark'); +assert.deepStrictEqual(marksByName.map((x) => x.entryType), ['mark', 'mark']); +const measuresByName = performance.getEntriesByName('a', 'measure'); +assert.deepStrictEqual(measuresByName.map((x) => x.entryType), ['measure', 'measure']); +const invalidTypeEntriesByName = performance.getEntriesByName('a', null); +assert.strictEqual(invalidTypeEntriesByName.length, 0); // getEntriesBy[Name|Type](undefined) performance.mark(undefined);