mirrors/nodejs
mirrors/nodejs
0
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 07:53:06 +01:00
Code Issues Releases Activity
e407478ebe
nodejs/.github/PULL_REQUEST_TEMPLATE.md

23 lines
731 B
Markdown
Raw Normal View History

doc: improve github templates by using comments Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-15 06:06:09 +01:00
<!--
doc: edit pull request template Move checklist instructions closer to the checklist. Trim unnecessary words. PR-URL: https://github.com/nodejs/node/pull/7058 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-05-30 07:32:12 +02:00
Thank you for your pull request. Please review below requirements.
github: add issue and pull request templates Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-17 21:48:00 +01:00
doc: minor rewording to the GitHub issue/pr templates - Templates are now a bit more consistent with phrasing. - Simplified a bit. PR-URL: https://github.com/nodejs/node/pull/7403 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-24 14:33:57 +02:00
Bug fixes and new features should include tests and possibly benchmarks.
github: add issue and pull request templates Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-17 21:48:00 +01:00
doc: make pull request template more concise PR-URL: https://github.com/nodejs/node/pull/7239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
2016-06-09 01:40:12 +02:00
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
doc: improve github templates by using comments Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-15 06:06:09 +01:00
-->
github: add issue and pull request templates Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-17 21:48:00 +01:00
doc: improve github templates by using comments Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-15 06:06:09 +01:00
##### Checklist
doc: edit pull request template Move checklist instructions closer to the checklist. Trim unnecessary words. PR-URL: https://github.com/nodejs/node/pull/7058 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-05-30 07:32:12 +02:00
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
github: add issue and pull request templates Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
2016-02-17 21:48:00 +01:00
build: change nosign flag to sign and flips logic Makes the default build on Windows not try to sign the node.exe binary after a build. Instead the 'sign' flag now indicates that the binary should be signed. The 'nosign' flag is left as a noop. Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: https://github.com/nodejs/node/pull/10156
2016-12-06 21:52:59 +01:00
- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
doc: minor rewording to the GitHub issue/pr templates - Templates are now a bit more consistent with phrasing. - Simplified a bit. PR-URL: https://github.com/nodejs/node/pull/7403 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-24 14:33:57 +02:00
- [ ] tests and/or benchmarks are included
doc: improve github templates by using comments Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-15 06:06:09 +01:00
- [ ] documentation is changed or added
doc: minor rewording to the GitHub issue/pr templates - Templates are now a bit more consistent with phrasing. - Simplified a bit. PR-URL: https://github.com/nodejs/node/pull/7403 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-24 14:33:57 +02:00
- [ ] commit message follows commit guidelines
github: put description of PR to the end of tmpl It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: https://github.com/nodejs/node/pull/5378 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2016-02-23 06:38:24 +01:00
doc: improve github templates by using comments Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-15 06:06:09 +01:00
##### Affected core subsystem(s)
doc: minor rewording to the GitHub issue/pr templates - Templates are now a bit more consistent with phrasing. - Simplified a bit. PR-URL: https://github.com/nodejs/node/pull/7403 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-24 14:33:57 +02:00
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->
doc: improve github templates by using comments Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-03-15 06:06:09 +01:00
##### Description of change
doc: minor rewording to the GitHub issue/pr templates - Templates are now a bit more consistent with phrasing. - Simplified a bit. PR-URL: https://github.com/nodejs/node/pull/7403 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-24 14:33:57 +02:00
<!-- Provide a description of the change below this comment. -->
Copy Permalink