mirrors/n
mirrors/n
0
0
Fork 0
mirror of https://github.com/tj/n.git synced 2024-11-25 07:39:21 +01:00
Code Issues Releases Wiki Activity

Fail for blank target from auto (or engine) version file (#693)

Browse Source 
* Fail unspecified auto rather than fall back to current

* Simplify wording
This commit is contained in:
John Gee 2021-10-16 15:13:48 +13:00 committed by GitHub
parent cc4d331ea7
commit d272114e94
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bin/n
View File

@ -1071,7 +1071,8 @@ function get_package_engine_version() {
local range
range="$(node -e "package = require('${filepath}'); if (package && package.engines && package.engines.node) console.log(package.engines.node)")"
verbose_log "read" "${range}"
if [[ -z "${range}" || "*" == "${range}" ]]; then
[[ -n "${range}" ]] || return 2
if [[ "*" == "${range}" ]]; then
verbose_log "target" "current"
g_target_node="current"
return
@ -1142,6 +1143,7 @@ function get_engine_version() {
break
done
[[ -n "${parent}" ]] || abort "${error_message}"
[[ -n "${g_target_node}" ]] || abort "did not find supported version of node in 'engines' field of package.json"
}
#
@ -1169,6 +1171,7 @@ function get_auto_version() {
done
# Fallback to package.json
[[ -n "${parent}" ]] || get_engine_version "no file found for auto version (.n-node-version, .node-version, .nvmrc, or package.json)"
[[ -n "${g_target_node}" ]] || abort "file found for auto did not contain target version of node"
}
#