mirrors/mongodb
mirrors/mongodb
0
0
Fork 0
mirror of https://github.com/mongodb/mongo.git synced 2024-12-01 09:32:32 +01:00
Code Issues Releases Activity

SERVER-17410: listCommands returns unordered list

Browse Source 
Closes #990

Signed-off-by: Jason Rassi <rassi@10gen.com>
This commit is contained in:
Upendra Gowda 2015-06-29 22:32:00 -05:00 committed by Jason Rassi
parent e38826d61c
commit de11b1cae5
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/mongo/db/dbcommands_generic.cpp
View File

@ -275,14 +275,19 @@ public:
int,
string& errmsg,
BSONObjBuilder& result) {
BSONObjBuilder b(result.subobjStart("commands"));
for (CommandMap::const_iterator i = _commands->begin(); i != _commands->end(); ++i) {
Command* c = i->second;
// sort the commands before building the result BSON
std::vector<Command*> commands;
for (CommandMap::const_iterator it = _commands->begin(); it != _commands->end(); ++it) {
// don't show oldnames
if (i->first != c->name)
continue;
if (it->first == it->second->name)
commands.push_back(it->second);
}
std::sort(commands.begin(),
commands.end(),
[](Command* lhs, Command* rhs) { return (lhs->name) < (rhs->name); });
BSONObjBuilder b(result.subobjStart("commands"));
for (const auto& c : commands) {
BSONObjBuilder temp(b.subobjStart(c->name));
{