mirrors/mongodb
mirrors/mongodb
0
0
Fork 0
mirror of https://github.com/mongodb/mongo.git synced 2024-12-01 09:32:32 +01:00
Code Issues Releases Activity

SERVER-50488 Fix race condition in PrimaryOnlyServiceTest unit test

Browse Source
This commit is contained in:
Spencer T Brody 2020-08-24 12:00:07 -04:00 committed by Evergreen Agent
parent 9a73ca0618
commit 8df4fa0dbe
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/mongo/db/repl/primary_only_service_test.cpp
View File

@ -412,17 +412,18 @@ TEST_F(PrimaryOnlyServiceTest, RecreateInstanceOnStepUp) {
stepDown();
TestServiceHangDuringStateTwo.setMode(FailPoint::off);
auto completionFPTimesEntered = TestServiceHangDuringCompletion.setMode(FailPoint::alwaysOn);
// Cannot use TestServiceHangDuringCompletion FP as at that point the Instance has deleted its
// state document and been removed from the service's registry.
stateOneFPTimesEntered = TestServiceHangDuringStateOne.setMode(FailPoint::alwaysOn);
stepUp();
recreatedInstance = TestService::Instance::lookup(_service, BSON("_id" << 0)).get();
ASSERT_EQ(TestService::State::kTwo, recreatedInstance->getInitialState());
TestServiceHangDuringCompletion.waitForTimesEntered(++completionFPTimesEntered);
ASSERT_EQ(TestService::State::kDone, recreatedInstance->getState());
TestServiceHangDuringCompletion.setMode(FailPoint::off);
TestServiceHangDuringStateOne.waitForTimesEntered(++stateOneFPTimesEntered);
TestServiceHangDuringStateOne.setMode(FailPoint::off);
recreatedInstance->waitForCompletion();
ASSERT_EQ(TestService::State::kDone, recreatedInstance->getState());
auto nonExistentInstance = TestService::Instance::lookup(_service, BSON("_id" << 0));
ASSERT(!nonExistentInstance.is_initialized());