mirrors/mongodb
mirrors/mongodb
0
0
Fork 0
mirror of https://github.com/mongodb/mongo.git synced 2024-12-01 01:21:03 +01:00
Code Issues Releases Activity

SERVER-49151 Fix linter to prevent malformed LOGV2 and assertion IDs

Browse Source
This commit is contained in:
Amirsaman Memaripour 2020-07-01 15:55:55 +00:00 committed by Evergreen Agent
parent 0ac64ca387
commit 813c96fc1e
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
buildscripts/errorcodes.py
View File

@ -26,6 +26,7 @@ except ImportError:
ASSERT_NAMES = ["uassert", "massert", "fassert", "fassertFailed"]
MINIMUM_CODE = 10000
MAXIMUM_CODE = 9999999 # JIRA Ticket + XX
# pylint: disable=invalid-name
codes = [] # type: ignore
@ -126,8 +127,9 @@ def read_error_codes():
errors = []
dups = defaultdict(list)
skips = []
malformed = [] # type: ignore
# define callback
# define validation callbacks
def check_dups(assert_loc):
"""Check for duplicates."""
codes.append(assert_loc)
@ -144,7 +146,18 @@ def read_error_codes():
dups[code].append(assert_loc)
errors.append(assert_loc)
parse_source_files(check_dups)
def validate_code(assert_loc):
"""Check for malformed codes."""
code = int(assert_loc.code)
if code > MAXIMUM_CODE:
malformed.append(assert_loc)
errors.append(assert_loc)
def callback(assert_loc):
validate_code(assert_loc)
check_dups(assert_loc)
parse_source_files(callback)
if "0" in seen:
code = "0"
@ -165,6 +178,11 @@ def read_error_codes():
line, col = get_line_and_column_for_position(loc)
print(" %s:%d:%d:%s" % (loc.sourceFile, line, col, loc.lines))
for loc in malformed:
line, col = get_line_and_column_for_position(loc)
print("MALFORMED ID: %s" % loc.code)
print(" %s:%d:%d:%s" % (loc.sourceFile, line, col, loc.lines))
return (codes, errors)