mirrors/mongodb
mirrors/mongodb
0
0
Fork 0
mirror of https://github.com/mongodb/mongo.git synced 2024-12-01 09:32:32 +01:00
Code Issues Releases Activity

SERVER-24927 Ignore NamespaceNotFound errors during initial sync apply ops

Browse Source
This commit is contained in:
Judah Schvimer 2016-07-07 14:12:25 -04:00
parent d7bae36fa7
commit 5227ccc46f
2 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mongo/db/repl/sync_tail.cpp
View File

@ -1160,6 +1160,12 @@ Status multiInitialSyncApply_noAbort(OperationContext* txn,
// subsequently got deleted and no longer exists on the Sync Target at all
}
} catch (const DBException& e) {
// SERVER-24927 If we have a NamespaceNotFound exception, then this document will be
// dropped before initial sync ends anyways and we should ignore it.
if (e.getCode() == ErrorCodes::NamespaceNotFound && entry.isCrudOpType()) {
continue;
}
severe() << "writer worker caught exception: " << causedBy(e) << " on: " << entry.raw;
if (e.toStatus() == ErrorCodes::InterruptedAtShutdown) {

22
src/mongo/db/repl/sync_tail_test.cpp
View File

@ -870,6 +870,28 @@ TEST_F(SyncTailTest,
ASSERT_FALSE(AutoGetCollectionForRead(_txn.get(), nss).getCollection());
}
TEST_F(SyncTailTest, MultiInitialSyncApplySkipsDocumentOnNamespaceNotFound) {
BSONObj emptyDoc;
SyncTailWithLocalDocumentFetcher syncTail(emptyDoc);
NamespaceString nss("local." + _agent.getSuiteName() + "_" + _agent.getTestName());
NamespaceString badNss("local." + _agent.getSuiteName() + "_" + _agent.getTestName() + "bad");
auto doc1 = BSON("_id" << 1);
auto doc2 = BSON("_id" << 2);
auto doc3 = BSON("_id" << 3);
auto op0 = makeCreateCollectionOplogEntry({Timestamp(Seconds(1), 0), 1LL}, nss);
auto op1 = makeInsertDocumentOplogEntry({Timestamp(Seconds(2), 0), 1LL}, nss, doc1);
auto op2 = makeInsertDocumentOplogEntry({Timestamp(Seconds(3), 0), 1LL}, badNss, doc2);
auto op3 = makeInsertDocumentOplogEntry({Timestamp(Seconds(4), 0), 1LL}, nss, doc3);
MultiApplier::OperationPtrs ops = {&op0, &op1, &op2, &op3};
ASSERT_OK(multiInitialSyncApply_noAbort(_txn.get(), &ops, &syncTail));
OplogInterfaceLocal collectionReader(_txn.get(), nss.ns());
auto iter = collectionReader.makeIterator();
ASSERT_EQUALS(doc3, unittest::assertGet(iter->next()).first);
ASSERT_EQUALS(doc1, unittest::assertGet(iter->next()).first);
ASSERT_EQUALS(ErrorCodes::CollectionIsEmpty, iter->next().getStatus());
}
TEST_F(SyncTailTest, MultiInitialSyncApplyRetriesFailedUpdateIfDocumentIsAvailableFromSyncSource) {
SyncTailWithLocalDocumentFetcher syncTail(BSON("_id" << 0 << "x" << 1));
NamespaceString nss("local." + _agent.getSuiteName() + "_" + _agent.getTestName());