mirrors/mongodb
mirrors/mongodb
0
0
Fork 0
mirror of https://github.com/mongodb/mongo.git synced 2024-12-01 09:32:32 +01:00
Code Issues Releases Activity

SERVER-35443 Update help text for shutdown commands and increase freeze time

Browse Source
This commit is contained in:
Tess Avitabile 2020-05-07 11:55:41 -04:00 committed by Evergreen Agent
parent c5f84d128c
commit 42acb126b4
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/mongo/db/commands/shutdown_d.cpp
View File

@ -53,7 +53,9 @@ Status stepDownForShutdown(OperationContext* opCtx,
// for any secondaries. Ignore stepdown.
if (replCoord->getConfig().getNumMembers() != 1) {
try {
replCoord->stepDown(opCtx, false /* force */, waitTime, Seconds(120));
// Specify a high freeze time, so that if there is a stall during shut down, the node
// does not run for election.
replCoord->stepDown(opCtx, false /* force */, waitTime, Days(1));
if (MONGO_unlikely(hangInShutdownAfterStepdown.shouldFail())) {
LOGV2(4695100, "hangInShutdownAfterStepdown failpoint enabled");
@ -81,12 +83,14 @@ namespace {
class CmdShutdownMongoD : public CmdShutdown<CmdShutdownMongoD> {
public:
std::string help() const override {
return "shutdown the database. must be ran against admin db and "
"either (1) ran from localhost or (2) authenticated. If "
"this is a primary in a replica set and there is no member "
"within 10 seconds of its optime, it will not shutdown "
"without force : true. You can also specify timeoutSecs : "
"N to wait N seconds for other members to catch up.";
return "Shuts down the database. Must be run against the admin database and either (1) run "
"from localhost or (2) run while authenticated with the shutdown privilege. If the "
"node is the primary of a replica set, waits up to 'timeoutSecs' for an electable "
"node to be caught up before stepping down. If 'force' is false and no electable "
"node was able to catch up, does not shut down. If the node is in state SECONDARY "
"after the attempted stepdown, any remaining time in 'timeoutSecs' is used for "
"quiesce mode, where the database continues to allow operations to run, but directs "
"clients to route new operations to other replica set members.";
}
static void beginShutdown(OperationContext* opCtx, bool force, long long timeoutSecs) {

8
src/mongo/s/commands/cluster_shutdown_cmd.cpp
View File

@ -38,10 +38,10 @@ namespace {
class ClusterShutdownCmd : public CmdShutdown<ClusterShutdownCmd> {
public:
std::string help() const override {
return "shutdown the database. must be ran against admin db and "
"either (1) ran from localhost or (2) authenticated. You can "
"also specify timeoutSecs : N to wait N seconds to allow in "
"progress operations to complete.";
return "Shuts down the mongos. Must be run against the admin database and either (1) run "
"from localhost or (2) run while authenticated with the shutdown privilege. Spends "
"'timeoutSecs' in quiesce mode, where the mongos continues to allow operations to "
"run, but directs clients to route new operations to other mongos nodes.";
}
static void beginShutdown(OperationContext* opCtx, bool force, long long timeoutSecs) {}