mirrors/mongodb
mirrors/mongodb
0
0
Fork 0
mirror of https://github.com/mongodb/mongo.git synced 2024-12-01 09:32:32 +01:00
Code Issues Releases Activity

SERVER-63512 Fix locking for optimized heartbeat reconfig

Browse Source
This commit is contained in:
Matthew Russotto 2022-03-18 19:03:12 +00:00 committed by Evergreen Agent
parent ff78f5988c
commit 2d60b58f16
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/mongo/db/repl/replication_coordinator_impl_heartbeat.cpp
View File

@ -725,15 +725,18 @@ void ReplicationCoordinatorImpl::_heartbeatReconfigStore(
const auto myIndex = [&]() -> StatusWith<int> {
// We always check the config when _selfIndex is not valid, in order to be able to
// recover from transient DNS errors.
if (_selfIndex >= 0 && sameConfigContents(_rsConfig, configToApply)) {
LOGV2_FOR_HEARTBEATS(
6351200,
2,
"New heartbeat config is only a version/term change, skipping validation checks",
"oldConfig"_attr = _rsConfig,
"newConfig"_attr = configToApply);
// If the configs are the same, so is our index.
return _selfIndex;
{
stdx::lock_guard<Latch> lk(_mutex);
if (_selfIndex >= 0 && sameConfigContents(_rsConfig, configToApply)) {
LOGV2_FOR_HEARTBEATS(6351200,
2,
"New heartbeat config is only a version/term change, skipping "
"validation checks",
"oldConfig"_attr = _rsConfig,
"newConfig"_attr = configToApply);
// If the configs are the same, so is our index.
return _selfIndex;
}
}
return validateConfigForHeartbeatReconfig(
_externalState.get(), configToApply, getGlobalServiceContext());