SERVER-48291 Remove need for individual third_party shim source files

SConstruct

@@ -1264,24 +1264,6 @@ env.AddMethod(mongo_platform.env_os_is_wrapper, 'TargetOSIs')
 env.AddMethod(mongo_platform.env_get_os_name_wrapper, 'GetTargetOSName')
 
 
-def shim_library(env, name, needs_link=False, *args, **kwargs):
-    nodes = env.Library(
-        target=f"shim_{name}" if name else name,
-        source=[
-            f"shim_{name}.cpp" if name else name,
-        ],
-        *args,
-        **kwargs
-    )
-
-    for n in nodes:
-        setattr(n.attributes, "needs_link", needs_link)
-
-    return nodes
-
-env.AddMethod(shim_library, 'ShimLibrary')
-
-
 def conf_error(env, msg, *args):
     print(msg.format(*args))
     print("See {0} for details".format(env.File('$CONFIGURELOG').abspath))

site_scons/libdeps_next.py

@@ -730,8 +730,6 @@ def _libdeps_visit(n, tsorted, marked, walking, debug=False):
                 _libdeps_visit_private(child, marked, walking, debug)
 
         marked[n.target_node] = LibdepsVisitationMark.MARKED_PUBLIC
-
-        if getattr(n.target_node.attributes, "needs_link", True):
         tsorted.append(n.target_node)
 
     except DependencyCycleError as e:

src/third_party/SConscript

@@ -223,6 +223,30 @@ env.AddMethod(injectThirdParty, 'InjectThirdParty')
 
 env = env.Clone()
 
+# Construct an empty object file that we can use to produce the
+# library for every shim. This avoids the need to create and name a
+# different empty source file for every third-party library, as we did
+# in the past.
+
+empty_source=env.Textfile(
+    target='third_party_shim.cpp',
+    source=str(),
+)
+env.Alias('generated-sources', empty_source)
+
+empty_object = env.LibraryObject(
+    target='third_party_shim',
+    source=empty_source,
+)
+
+def shim_library(env, name, **kwargs):
+    return env.Library(
+        target=f"shim_{name}",
+        source=empty_object[0],
+        **kwargs,
+    )
+env.AddMethod(shim_library, 'ShimLibrary')
+
 murmurEnv = env.Clone()
 murmurEnv.InjectThirdParty(libraries=['fmt'])
 murmurEnv.SConscript('murmurhash3/SConscript', exports={ 'env' : murmurEnv })

src/third_party/shim_abseil.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_abseil.cpp is part of the
-// third_party/abseil-cpp library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_allocator.cpp

@@ -1,2 +0,0 @@
-// This file intentionally blank.  shim_allocator.cpp is part of the third_party/shim_allocator
-// library, used to manage memory allocator selection (tcmalloc, libc, etc.).

src/third_party/shim_asio.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_asio.cpp is part of the
-// third_party/asio library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_benchmark.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank. shim_benchmark.cpp is part of the
-// third_party/benchmark library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_boost.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_boost.cpp is part of the
-// third_party/boost library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_fmt.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_fmt.cpp is part of the
-// third_party/fmt library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_icu.cpp

@@ -1,2 +0,0 @@
-// This file intentionally blank.  shim_icu.cpp is part of the third_party/icu library, which is
-// just a placeholder for forwarding library dependencies.

src/third_party/shim_intel_decimal128.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_intel_decimal128.cpp is part of the
-// third_party/IntelRDFPMathLib20U1 library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_kms_message.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_kms_message.cpp is part of the
-// third_party/kms_message library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_mozjs.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_mozjs.cpp is part of the
-// third_party/mozjs library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_pcrecpp.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_pcrecpp.cc is part of the
-// third_party/pcrecpp library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_snappy.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_snappy.cpp is part of the
-// third_party/snappy library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_stemmer.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_stemmer.cpp is part of the
-// third_party/libstemmer_c library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_timelib.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_timelib.cpp is part of the
-// third_party/timelib library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_tomcrypt.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_tomcrypt.cpp is part of the
-// third_party/tomcrypt library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_unwind.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_unwind.cpp is part of the
-// third_party/unwind library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_v8.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_v8.cpp is part of the
-// third_party/v8 library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_wiredtiger.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_wiredtiger.cpp is part of the
-// third_party/wiredtiger library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_yaml.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_yaml.cpp is part of the
-// third_party/yaml library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_zlib.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_zlib.cpp is part of the
-// third_party/zlib library, which is just a placeholder for forwarding
-// library dependencies.

src/third_party/shim_zstd.cpp

@@ -1,3 +0,0 @@
-// This file intentionally blank.  shim_zstd.cpp is part of the
-// third_party/zstandard library, which is just a placeholder for forwarding
-// library dependencies.