mirrors/mongodb
mirrors/mongodb
0
0
Fork 0
mirror of https://github.com/mongodb/mongo.git synced 2024-12-01 01:21:03 +01:00
Code Issues Releases Activity

SERVER-42212 Make config server wait for majority before sending _flushDatabaseCacheUpdates to primary shard

Browse Source
This commit is contained in:
Esha Maharishi 2019-07-15 15:29:55 -04:00
parent 44080f6542
commit 0b1c9766ec
2 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
jstests/sharding/database_versioning_safe_secondary_reads.js
View File

@ -29,12 +29,13 @@
checkOnDiskDatabaseVersion(st.rs0.getSecondary(), dbName, undefined);
checkOnDiskDatabaseVersion(st.rs1.getSecondary(), dbName, undefined);
// Use 'enableSharding' to create the database only in the sharding catalog (the database will
// not exist on any shards). Manually update the 'primary' field in the new dbEntry in
// config.databases so that we know which shard is the primary.
assert.commandWorked(st.s.adminCommand({enableSharding: dbName}));
assert.commandWorked(st.s.getDB("config").getCollection("databases").update({_id: dbName}, {
$set: {primary: st.rs1.name}
// Manually insert an entry for 'dbName' into config.databases so that we can choose shard1 as
// the primary shard.
assert.commandWorked(st.s.getDB("config").getCollection("databases").insert({
_id: dbName,
primary: st.rs1.name,
partitioned: false,
version: {uuid: new UUID(), lastMod: NumberInt(1)},
}));
// Check that a command that attaches databaseVersion returns empty results, even though the
@ -190,15 +191,15 @@
checkOnDiskDatabaseVersion(st.rs0.getSecondary(), dbName, undefined);
checkOnDiskDatabaseVersion(st.rs1.getSecondary(), dbName, undefined);
// Use 'enableSharding' to create the database only in the sharding catalog (the database will
// not exist on any shards).
assert.commandWorked(st.s.adminCommand({enableSharding: dbName}));
// Simulate that the database was created on 'shard0' by directly modifying the database entry
// (we cannot use movePrimary, since movePrimary creates the database on the shards).
assert.writeOK(st.s.getDB("config").getCollection("databases").update({_id: dbName}, {
$set: {primary: st.shard0.shardName}
// Manually insert an entry for 'dbName' into config.databases so that we can choose shard0 as
// the primary shard.
assert.commandWorked(st.s.getDB("config").getCollection("databases").insert({
_id: dbName,
primary: st.rs0.name,
partitioned: false,
version: {uuid: new UUID(), lastMod: NumberInt(1)},
}));
const dbEntry = st.s.getDB("config").getCollection("databases").findOne({_id: dbName});
assert.commandWorked(st.s.getDB(dbName).runCommand({listCollections: 1}));

4
src/mongo/db/s/config/sharding_catalog_manager_database_operations.cpp
View File

@ -117,8 +117,10 @@ DatabaseType ShardingCatalogManager::createDatabase(OperationContext* opCtx,
log() << "Registering new database " << db << " in sharding catalog";
// Do this write with majority writeConcern to guarantee that the shard sees the write when it
// receives the _flushDatabaseCacheUpdates.
uassertStatusOK(Grid::get(opCtx)->catalogClient()->insertConfigDocument(
opCtx, DatabaseType::ConfigNS, db.toBSON(), ShardingCatalogClient::kLocalWriteConcern));
opCtx, DatabaseType::ConfigNS, db.toBSON(), ShardingCatalogClient::kMajorityWriteConcern));
// Send _flushDatabaseCacheUpdates to the primary shard
const auto shard =